Fix namespaces deletion handling #159
Conversation
Following #156 some conflicts are happening, do you think you might have some time to take a look? |
…, especially in 'data.valueFrom'
tr-aheiev
force-pushed
the
fix-namespaces-deletion-handling
branch
from
5465f70 to
dbabc96
Compare
|
Hi! I updated the code. Not sure - do I need to bump Chart version each time to pass tests? |
Yes, I cannot change the GitHub workflows, so need to bump it to let it pass :/ |
| @@ -116,143 +116,6 @@ def test_on_field_data_sync(self): | |||
| {"key": "newvalue"}, | |||
| ) | |||
|
|
|||
| def test_on_field_data_ns_deleted(self): | |||
There was a problem hiding this comment.
The test has been removed, could you clarify? If the changes fixes an issue, we should have a regression tests, otherwise if it is adding a new behaviour, we should ensure it works as expected
There was a problem hiding this comment.
Yes, you are right. Previously 'on_field_data' function was doing little more than now, so there was additional test for it and I removed it after it changes. But now when I added new functionality into 'namespace_watcher' function, seems I need to write some additional test for it. I will try to do this today/tomorrow.
There was a problem hiding this comment.
Thanks! Really appreciate!
This PR removes outdated code from 'on_field_data' and simplifying secrets synchronization for both types - with inline data fields and with external secrets (with 'valueFrom' field). But after removing that code we need somehow handle namespace deletion operations - for this purpose I refactored 'namespace_watcher' function. Test for namespace creation I fixed also, but for namespace removing need to create new - not sure that can handle it myself, but will try.
All current tests are passed.